Skip to content

feat(pack): support useDefineForClassFields - #2452

Merged
xusd320 merged 3 commits into
nextfrom
support-useDefineForClassFileds
Dec 25, 2025
Merged

feat(pack): support useDefineForClassFields#2452
xusd320 merged 3 commits into
nextfrom
support-useDefineForClassFileds

Conversation

@fireairforce

Copy link
Copy Markdown
Member

Summary

closes: #2450

Test Plan

添加了快照测试

@fireairforce fireairforce changed the title feat(turbopack): support useDefineForClassFields feat(pack): support useDefineForClassFields Dec 25, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances Turbopack's TypeScript support by updating the default behavior for the useDefineForClassFields compiler option to true. This change ensures that class fields are defined using Object.defineProperty, which is crucial for consistent behavior across different JavaScript environments and inheritance scenarios. The update also includes new snapshot tests to verify the proper implementation and a minor cleanup in an existing test snapshot.

Highlights

  • useDefineForClassFields Default: The default value for the useDefineForClassFields TypeScript compiler option has been changed from false to true within Turbopack's transformation options, aligning with modern TypeScript behavior.
  • Snapshot Test Cleanup: An unnecessary dependencyChain property declaration was removed from the UpdateApplyError class in a runtime snapshot test file.
  • New Snapshot Tests: Comprehensive snapshot tests have been added to validate the correct handling of the useDefineForClassFields option, including specific configurations and expected output.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new snapshot test case to validate the behavior of TypeScript's useDefineForClassFields compiler option when set to false. Concurrently, the default value for useDefineForClassFields in the get_typescript_transform_options function was updated from false to true when not explicitly defined in the tsconfig.json. A minor cleanup was also performed in an existing snapshot test output by removing a dependencyChain declaration. The review comments suggest improving the clarity of the new test case's BrowserFsProvider class by explicitly declaring the opFs property and adding a comment to explain that opfsFsProvider is intentionally uninitialized to test specific compiler output, as its current state would lead to a runtime TypeError.

@xusd320
xusd320 merged commit 3f960c1 into next Dec 25, 2025
32 checks passed
@xusd320
xusd320 deleted the support-useDefineForClassFileds branch December 25, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Utoopack] useDefineForClassFields 配置不生效

2 participants