feat(pack): support useDefineForClassFields - #2452
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances Turbopack's TypeScript support by updating the default behavior for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new snapshot test case to validate the behavior of TypeScript's useDefineForClassFields compiler option when set to false. Concurrently, the default value for useDefineForClassFields in the get_typescript_transform_options function was updated from false to true when not explicitly defined in the tsconfig.json. A minor cleanup was also performed in an existing snapshot test output by removing a dependencyChain declaration. The review comments suggest improving the clarity of the new test case's BrowserFsProvider class by explicitly declaring the opFs property and adding a comment to explain that opfsFsProvider is intentionally uninitialized to test specific compiler output, as its current state would lead to a runtime TypeError.
Summary
closes: #2450
Test Plan
添加了快照测试