Skip to content

refactor(pack): library chunk use turbopack-core's clean_separators - #2459

Merged
fireairforce merged 1 commit into
nextfrom
adjust-clean-seperators
Dec 26, 2025
Merged

refactor(pack): library chunk use turbopack-core's clean_separators#2459
fireairforce merged 1 commit into
nextfrom
adjust-clean-seperators

Conversation

@fireairforce

Copy link
Copy Markdown
Member

Summary

library 打包使用跟 app 一样的 clean_seperators 方法逻辑

Test Plan

没有测试变化

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求重构了 clean_separators 工具函数,将其重新定位到更核心的 turbopack_core 模块中。此更改旨在标准化不同打包上下文中的路径清理逻辑,特别是确保库分块能够受益于与应用程序分块相同的健壮分隔符清理机制。

Highlights

  • 统一分隔符清理逻辑: 将 clean_separators 函数从 turbopack_browser::chunking_context 移动到 turbopack_core::ident,以确保库打包和应用打包使用相同的路径清理逻辑。
  • 依赖更新: 更新了 next.js 子项目的提交哈希。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次代码重构将 library 打包逻辑中使用的 clean_separators 函数统一为 turbopack-core 中的实现,与 app 打包逻辑保持一致。这是一个值得称赞的改进,因为它提高了代码库的一致性,降低了未来的维护成本。代码变更清晰、目的明确,我没有发现任何问题。

@fireairforce
fireairforce force-pushed the adjust-clean-seperators branch from 48e4172 to 5f48180 Compare December 26, 2025 06:30
@fireairforce
fireairforce merged commit b1c5cd0 into next Dec 26, 2025
21 checks passed
@fireairforce
fireairforce deleted the adjust-clean-seperators branch December 26, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant