Skip to content

feat(pack): update to next.js@16.1 - #2478

Merged
xusd320 merged 3 commits into
nextfrom
feat/next.js-16.1
Jan 4, 2026
Merged

feat(pack): update to next.js@16.1#2478
xusd320 merged 3 commits into
nextfrom
feat/next.js-16.1

Conversation

@xusd320

@xusd320 xusd320 commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

Upgrade to next.js@16.1

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a comprehensive update to the pack system, primarily driven by an upgrade to next.js@16.1 and its underlying SWC ecosystem. The changes encompass a significant overhaul of internal data serialization using bincode, leading to a more robust and potentially faster build process. Furthermore, the PR introduces advanced tree-shaking mechanisms for improved code optimization and refines source map management. These updates aim to enhance the overall performance, maintainability, and feature set of the pack system.

Highlights

  • Dependency Upgrades: The core pack system has been updated to align with next.js@16.1, which includes significant upgrades across various swc_* crates (e.g., swc_core from 45.0.1 to 49.0.0, swc_atoms from 7.0.0 to 9.0.0, swc_common from 15.0.0 to 18.0.0, and many others) and other related packages like modularize_imports, remove_console, styled_components, and testing.
  • Serialization Refactor with bincode: A major refactor of turbo_tasks value serialization has been implemented, transitioning from manual serde attributes and NonLocalValue/TraceRawVcs traits to leveraging bincode for many internal structs. This introduces the new turbo-bincode crate and integrates bincode for efficient binary serialization across various pack-api and pack-core components.
  • Enhanced Tree-Shaking and Binding Usage Analysis: The system now incorporates more granular tree-shaking capabilities through the introduction of BindingUsageInfo. This allows for more precise analysis of used exports and unused imports, enabling better optimization and dead code elimination. New functions like binding_usage_info and unused_references have been added to the Project struct.
  • Source Map Handling Improvements: The internal handling of source maps has been refactored, replacing OptionStringifiedSourceMap with FileContent for consistency and efficiency. This change impacts how source maps are retrieved and processed within pack-api and pack-core.
  • New Turbopack Crates Integration: New turbopack-css and turbopack-resolve crates have been integrated into the build system, indicating expanded capabilities for CSS processing and module resolution.
  • MDX Processing Adjustments: Specific handling for mdx_rs has been removed from several transform rules and the Config struct, suggesting a streamlined or altered approach to how MDX files are processed within the build pipeline.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades next.js to version 16.1, which involves a significant number of dependency updates and API changes, primarily within the turbopack and turbo_tasks ecosystem. The changes look mostly correct, adapting to the new APIs. The refactoring of many structs to use #[turbo_tasks::value] is a great improvement for code clarity and conciseness.

I've identified a critical logic issue in source map handling and a couple of maintainability concerns regarding forked dependencies and a temporary workaround for resolve origins. Please see the detailed comments for more information.

Comment thread crates/pack-api/src/source_map.rs
Comment thread Cargo.toml
fireairforce
fireairforce previously approved these changes Jan 4, 2026
@xusd320
xusd320 force-pushed the feat/next.js-16.1 branch from 31601ad to 365a0c2 Compare January 4, 2026 10:45
@xusd320
xusd320 merged commit 65e8bdf into next Jan 4, 2026
21 checks passed
@xusd320
xusd320 deleted the feat/next.js-16.1 branch January 4, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants