fix(wasm): use latest forked libmimalloc and update deps - #2517
Conversation
Summary of ChangesHello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on maintaining the project's dependencies and configurations. It updates several key libraries to their latest versions, refines the WASM build process by fixing a mimalloc configuration, and enhances the WASM tracing capabilities. Additionally, it includes minor adjustments to the demo application's build process and updates a core submodule, ensuring the project remains current and stable. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
- Update tokio-fs-ext to 0.7.1 - Fix mimalloc patch (remove explicit package name) - Enable span events logging in WASM tracing - Enable nodePolyFill in utooweb-demo config - Include package-lock.json in demo files
399e5d9 to
b10cd34
Compare
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on updating dependencies, including libmimalloc and tokio-fs-ext, and refining configurations for the WASM build. The changes align well with the description, such as enabling span event logging for better debugging and adjusting the mimalloc patch. My review includes a minor suggestion to improve code cleanliness by removing commented-out code instead of leaving it in the codebase. Overall, the changes are straightforward and beneficial.
Changes
tokio-fs-extto 0.7.1nodePolyFillin utooweb-demo config