fix(pack): lightningcss support parse put function under var() - #2534
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where lightningcss failed to parse rgba() functions within var() by updating the lightningcss dependency to a newer version from a forked repository. The change is accompanied by a new snapshot test that correctly verifies the fix. The implementation is correct and effectively resolves the described problem. I have one minor suggestion regarding the organization of the new test case to improve maintainability.
|
lightningcss commit 关联到 pr 描述里 |
done 了 |
Summary
utooland/lightningcss@af747bd
Before:
After:
Test Plan
添加了测试