Skip to content

fix(pack): lightningcss support parse put function under var() - #2534

Merged
fireairforce merged 1 commit into
nextfrom
fix-unexpected-token
Jan 22, 2026
Merged

fix(pack): lightningcss support parse put function under var()#2534
fireairforce merged 1 commit into
nextfrom
fix-unexpected-token

Conversation

@fireairforce

@fireairforce fireairforce commented Jan 22, 2026

Copy link
Copy Markdown
Member

Summary

utooland/lightningcss@af747bd

Before:

image

After:

image

Test Plan

添加了测试

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where lightningcss failed to correctly parse rgba() functions when used inside var() CSS functions. The primary change involves updating the lightningcss dependency to a version that incorporates this fix. To ensure the regression does not occur, a new test case has been introduced, demonstrating the proper handling and compilation of such CSS constructs.

Highlights

  • Dependency Updates: The lightningcss dependency has been updated to version 1.0.0-alpha.70, along with its related derive and selector packages. Additionally, itertools and hashbrown dependencies were downgraded to 0.12.1 and 0.15.5 respectively.
  • CSS Parsing Fix: This pull request includes a fix for lightningcss to correctly parse and handle rgba() functions when they are nested within var() CSS functions.
  • New Test Case: A new test case has been added to crates/pack-tests to validate the correct parsing and transformation of CSS rules containing var(rgba(...)).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where lightningcss failed to parse rgba() functions within var() by updating the lightningcss dependency to a newer version from a forked repository. The change is accompanied by a new snapshot test that correctly verifies the fix. The implementation is correct and effectively resolves the described problem. I have one minor suggestion regarding the organization of the new test case to improve maintainability.

@xusd320

xusd320 commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

lightningcss commit 关联到 pr 描述里

@fireairforce

Copy link
Copy Markdown
Member Author

lightningcss commit 关联到 pr 描述里

done 了

@fireairforce
fireairforce merged commit 6a04cdb into next Jan 22, 2026
15 checks passed
@fireairforce
fireairforce deleted the fix-unexpected-token branch January 22, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants