fix(pack): invalid css url request should throw waring instead of error - #2535
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the build process's handling of invalid CSS Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly implements the intended change of converting an error into a warning for invalid CSS url() requests. This is supported by the addition of new snapshot tests that demonstrate the new warning behavior. My review includes a suggestion to correct the CSS syntax in one of the new test cases to ensure the test is precise and avoids unrelated CSS invalidity.
c32d9bb to
aad1fd7
Compare
Summary
upstream pr: utooland/next.js#105
closes: #2278
Test Plan
添加了快照测试。