Closed
Remove Copy trait from BuildEvent and PackageTarballInfo#2581
Conversation
Co-authored-by: xusd320 <16577489+xusd320@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on pipeline deps resolver refactor for Copy implementation
Remove Copy trait from BuildEvent and PackageTarballInfo
Feb 10, 2026
Contributor
|
Copilot 这个说法有点教条了。它的逻辑是:"event 代表一次性的状态变更,不应该被随意复制"。 但这里的 BuildEvent<'a> 并不拥有任何数据——它全是借用引用(&'a str、&'a Path),本质上就是一个只读视图。Copy 它不会复制任何实际状态,只是多了一个指向相同数据的指针。这跟复制一个拥有 如果是 BuildEvent 持有 String、PathBuf 这些 owned 类型,那 Copilot 说的有道理——随意 Copy/Clone 会有性能和语义问题。但对一个全是引用的轻量 enum,Copy 就是最自然的选择。 实际上你也可以问 Copilot:不用 Copy 的话怎么解决 PipelineReceiver::on_event 里 event 被用两次的问题?它只能建议你 .clone()——对一个全是引用的类型手动 clone,反而更别扭。 @xusd320 😄 他们打起来了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Copytrait was implemented onBuildEvent<'a>andPackageTarballInfo<'a>despite these being event types containing borrowed references. While technically valid (all fields areCopy), this is semantically incorrect—events represent discrete state changes and shouldn't be trivially duplicated.Changes
Copyfrom event types:BuildEvent<'a>andPackageTarballInfo<'a>now derive onlyClonePipelineReceiver::on_eventto explicitly clone the event when forwarding to inner receiverThis follows Rust idioms where
ClonewithoutCopysignals that duplication has semantic weight, appropriate for event types.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.