Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions crates/pack-core/src/library/chunking_context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -273,22 +273,22 @@ impl LibraryChunkingContext {
chunk: Vc<Box<dyn Chunk>>,
evaluatable_assets: Vc<EvaluatableAssets>,
) -> Result<Vc<Box<dyn OutputAsset>>> {
let chunk = chunk.to_resolved().await?;
Ok(
if let Some(ecmascript_chunk) =
Vc::try_resolve_downcast_type::<EcmascriptChunk>(chunk).await?
if let Some(ecmascript_chunk) = ResolvedVc::try_downcast_type::<EcmascriptChunk>(chunk)
{
let ident =
self.ecmascript_chunk_ident_with_filename_template(ident, ecmascript_chunk);
self.ecmascript_chunk_ident_with_filename_template(ident, *ecmascript_chunk);
Vc::upcast(EcmascriptLibraryEvaluateChunk::new(
self,
ident,
ecmascript_chunk,
*ecmascript_chunk,
evaluatable_assets,
))
Comment thread
fireairforce marked this conversation as resolved.
} else if let Some(output_asset) =
Vc::try_resolve_sidecast::<Box<dyn OutputAsset>>(chunk).await?
ResolvedVc::try_sidecast::<Box<dyn OutputAsset>>(chunk)
{
output_asset
*output_asset
Comment thread
fireairforce marked this conversation as resolved.
} else {
bail!("Unable to generate output asset for chunk");
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 15 additions & 6 deletions crates/pack-tests/tests/snapshot/public_path/basic/output/main.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading