feat(pack): napi add pluginRuntimeStratefy type#2677
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the configuration capabilities of the packing process by adding a new option to control the runtime strategy for NAPI plugins within Turbopack-node. This allows for explicit selection between Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new pluginRuntimeStrategy option to the configuration, allowing control over the runtime strategy for plugins. The change itself is correct, but the corresponding JSON schema in packages/pack/config_schema.json should also be updated to include this new property for validation and autocompletion. Additionally, there is a minor typo in the pull request title ('Stratefy' should be 'Strategy').
| importSource?: string; | ||
| }; | ||
| stats?: boolean; | ||
| pluginRuntimeStrategy?: "workerThreads" | "childProcesses"; |
There was a problem hiding this comment.
📊 Performance Benchmark Report (with-antd)Utoopack Performance Report (Intelligent)Report ID: Executive SummaryKey Findings
Workload Distribution by Tier
🤖 AI Intelligent AttributionsNew section mapping granular tasks to bottlenecks. Top 10 Batching CandidatesThese highly-called tasks are dominated by a single parent. If the parent can batch them into one call, it drastically reduces scheduler overhead.
Top 20 Tasks by Total Duration
Duration Distribution
Action Items
Report generated by Intelligent Utoopack Performance Analysis Agent |
Summary
add a napi type for turbopack-node to control runtime strategy.
Test Plan