feat(pack): support styles.postcss#2708
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for inline PostCSS configuration, allowing users to define PostCSS plugins directly within their utoopack.config.mjs file. This was implemented by adding a postcss field to the StyleConfig and SchemaStyleConfig structures, and integrating logic in both client and server contexts to serialize and apply this configuration. A new example, examples/with-postcss, was added to demonstrate this feature, showcasing how postcss-plugin-px2rem can be used inline. The review noted that the logic for retrieving and serializing the inline PostCSS configuration is duplicated in both client and server contexts, suggesting it should be extracted into a shared helper function to improve maintainability.
552cec6 to
5ec92b2
Compare
| let postcss_transform_options = Some(PostCssTransformOptions { | ||
| postcss_package: Some(get_postcss_package_mapping().to_resolved().await?), | ||
| config_location: PostCssConfigLocation::ProjectPathOrLocalPath, | ||
| inline_config: inline_postcss_config, |
There was a problem hiding this comment.
ok,inline_config 容易跟 inline_style 这种搞混
42702af to
363761b
Compare
📊 Performance Benchmark Report (with-antd)Utoopack Performance ReportReport ID: Executive Summary
Build Phase TimelineShows when each build phase is active and how much CPU it consumes.
Workload Distribution by Diagnostic Tier
Top 20 Tasks by Self-TimeSelf-time is the exclusive duration: time spent in the task itself, not in sub-tasks.
Critical Path AnalysisThe longest sequential dependency chains that determine wall-clock time.
Batching CandidatesHigh-volume tasks dominated by a single parent. If the parent can batch them,
Duration Distribution
Action Items
Report generated by Utoopack Performance Analysis Agent |
Summary
upstream: utooland/next.js#124
Support
styles.postcssto pass inline postcss config to turbopack than create apostcss.config.jsfile under framework case:Test Plan
add a example to show the case.