fix(pm): skip npm binary mirror lookup#2850
Closed
killagu wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an early return in the update_package_binary function to skip binary mirror updates when applicable. It refactors the skip logic into a new helper function, should_skip_binary_mirror_for_registry, updates the associated debug logging, and adds unit tests to verify the registry-based skip logic. I have no feedback to provide.
Contributor
|
Closing as stale: this draft is a one-off agent experiment from 2026-04-27 with no follow-up, and overlaps with sibling PRs exploring the same optimization. Reopen if revisited. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo fmt -p utoo-pmcargo test -p utoo-pm service::binary::tests::test_should_skip_binary_mirror_for_npm_registrycargo build -p utoo-pm --profile release-localcargo clippy -p utoo-pm --all-targets -- -D warnings --no-depscargo test -p utoo-pmPATH=/home/killa/multica_workspaces/56c053c2-a029-45bb-a3f8-c83499005c8a/f45d2706/workdir/utoo/target/release-local:$PATH BENCH_RUNS=1 PM_LIST=utoo BENCH_DIR=/tmp/pm-bench-eggd RESULTS_DIR=/tmp/pm-bench-results-eggd UTOO_CACHE=/tmp/utoo-bench-cache-eggd bash bench/pm-bench-phases.shBenchmark summary,
PM_LIST=utoo, single run:Note: full workspace
cargo clippy --all-targets -- -D warnings --no-depsis blocked in this runner by missing systempkg-config/OpenSSL for unrelated workspace dependencies; package-scoped PM clippy passed.