perf(pm): bound concurrent package clones#2853
Open
killagu wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a concurrency limit for filesystem clone operations in crates/pm/src/util/cloner.rs by implementing a tokio::sync::Semaphore. The limit is dynamically calculated based on available parallelism to mitigate scheduler churn and filesystem contention. Feedback suggests moving the semaphore acquisition to encompass the remove_dir_all operation, as it is a heavy filesystem task that could contribute to the contention the PR aims to prevent.
Contributor
There was a problem hiding this comment.
Pull request overview
Bounds concurrent package clone/hardlink/copy work in utoo-pm to reduce blocking-pool scheduling churn and filesystem contention during installs (notably warm-link scenarios).
Changes:
- Introduced a process-wide semaphore to limit concurrent filesystem clone operations.
- Added a helper to derive the clone concurrency limit from available parallelism.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Issue: EGG-20