perf(pm): require manifest provider for builder#3041
Closed
elrrrrrrr wants to merge 1 commit into
Closed
Conversation
elrrrrrrr
added
A-Pkg Manager
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dependency resolver in crates/ruborist/src/resolver/builder.rs by replacing the RegistryClient trait bound with ManifestProvider and adding a Send requirement for the error type across several public functions, including build_deps and resolve. These changes are implemented using where clauses for improved readability. I have no feedback to provide.
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-placement-helpers
branch
from
b9501b4 to
ab1867e
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-builder-provider-bound
branch
from
68f5209 to
845d350
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-placement-helpers
branch
from
ab1867e to
e677e3a
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-builder-provider-bound
branch
from
845d350 to
82721ee
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-placement-helpers
branch
from
e677e3a to
48257d5
Compare
elrrrrrrr
force-pushed
the
perf/pm-split-resolver-builder-provider-bound
branch
from
82721ee to
0520cea
Compare
📊 pm-bench-phases ·
|
| PM | wall | ±σ | user | sys | RSS | pgMinor |
|---|---|---|---|---|---|---|
| bun | 9.98s | 0.28s | 10.30s | 10.17s | 577M | 312.9K |
| utoo-next | 8.21s | 0.13s | 10.49s | 12.21s | 1007M | 125.9K |
| utoo-npm | 9.83s | 1.48s | 11.03s | 12.75s | 967M | 123.5K |
| utoo | 8.78s | 0.26s | 11.08s | 12.54s | 1004M | 129.8K |
| PM | vCtx | iCtx | netRX | netTX | cache | node_mod | lock |
|---|---|---|---|---|---|---|---|
| bun | 24.3K | 17.0K | 1.19G | 7M | 1.86G | 1.75G | 1M |
| utoo-next | 127.1K | 96.9K | 1.16G | 5M | 1.71G | 1.70G | 2M |
| utoo-npm | 162.3K | 118.3K | 1.16G | 6M | 1.71G | 1.70G | 2M |
| utoo | 141.6K | 84.0K | 1.17G | 6M | 1.71G | 1.70G | 2M |
p1_resolve
| PM | wall | ±σ | user | sys | RSS | pgMinor |
|---|---|---|---|---|---|---|
| bun | 2.88s | 0.05s | 3.87s | 1.15s | 502M | 167.7K |
| utoo-next | 3.37s | 0.04s | 5.23s | 1.98s | 606M | 87.0K |
| utoo-npm | 4.56s | 1.89s | 5.33s | 2.37s | 618M | 80.9K |
| utoo | 3.35s | 0.10s | 5.77s | 2.15s | 625M | 93.3K |
| PM | vCtx | iCtx | netRX | netTX | cache | node_mod | lock |
|---|---|---|---|---|---|---|---|
| bun | 16.1K | 2.9K | 202M | 3M | 108M | - | 1M |
| utoo-next | 58.9K | 79.7K | 200M | 3M | 7M | 3M | 2M |
| utoo-npm | 85.6K | 97.0K | 200M | 3M | 7M | 3M | 2M |
| utoo | 63.2K | 81.7K | 202M | 3M | 7M | 3M | 2M |
p3_cold_install
| PM | wall | ±σ | user | sys | RSS | pgMinor |
|---|---|---|---|---|---|---|
| bun | 7.10s | 0.30s | 6.35s | 9.79s | 549M | 196.9K |
| utoo-next | 8.33s | 1.86s | 5.29s | 11.02s | 492M | 65.0K |
| utoo-npm | 6.74s | 0.15s | 5.29s | 10.83s | 470M | 59.0K |
| utoo | 8.94s | 2.14s | 5.24s | 10.91s | 509M | 63.6K |
| PM | vCtx | iCtx | netRX | netTX | cache | node_mod | lock |
|---|---|---|---|---|---|---|---|
| bun | 10.6K | 8.2K | 1019M | 5M | 1.76G | 1.76G | 1M |
| utoo-next | 133.2K | 57.0K | 990M | 4M | 1.70G | 1.70G | 2M |
| utoo-npm | 120.7K | 55.6K | 990M | 3M | 1.70G | 1.70G | 2M |
| utoo | 130.4K | 55.9K | 990M | 4M | 1.70G | 1.70G | 2M |
p4_warm_link
| PM | wall | ±σ | user | sys | RSS | pgMinor |
|---|---|---|---|---|---|---|
| bun | 3.28s | 0.14s | 0.19s | 2.44s | 134M | 32.6K |
| utoo-next | 2.27s | 0.10s | 0.48s | 3.75s | 79M | 18.0K |
| utoo-npm | 2.36s | 0.15s | 0.48s | 3.79s | 80M | 18.4K |
| utoo | 2.18s | 0.15s | 0.48s | 3.75s | 79M | 18.5K |
| PM | vCtx | iCtx | netRX | netTX | cache | node_mod | lock |
|---|---|---|---|---|---|---|---|
| bun | 298 | 29 | 5M | 31K | 1.91G | 1.75G | 1M |
| utoo-next | 41.6K | 19.0K | 11K | 29K | 1.70G | 1.70G | 2M |
| utoo-npm | 43.0K | 19.4K | 11K | 11K | 1.70G | 1.70G | 2M |
| utoo | 41.8K | 19.8K | 12K | 9K | 1.71G | 1.70G | 2M |
npmmirror.com: no output captured.
Contributor
Author
|
Closing this temporary fine-grained draft split. We are replacing it with a smaller 9-PR review stack based on the source PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManifestProviderfor resolver builder entry pointsValidation
cargo fmtcargo check -p utoo-ruboristcargo test -p utoo-ruborist resolver::builder::tests::test_build -- --nocapturecargo test -p utoo-ruborist resolver::builder::tests::test_resolve_high_level_api -- --nocapturecargo clippy --all-targets -- -D warnings --no-depsSplit Plan
Part of the resolver stack split from source PR #3028. This PR is the final type-bound preparation before replacing preload+BFS with the demand manifest mainloop.