fix(pack): preserve updates during HMR subscription setup - #3304
Conversation
|
Turbopack-side changes have been split into a standalone draft PR: utooland/next.js#182 This PR keeps the Utoo protocol/NAPI integration and points the submodule at those Turbopack commits. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6563b825c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📊 Performance Benchmark Report (with-antd)Utoopack Performance ReportReport ID: Executive Summary
Build Phase TimelineShows when each build phase is active and how much CPU it consumes.
Workload Distribution by Diagnostic Tier
Top 20 Tasks by Self-TimeSelf-time is the exclusive duration: time spent in the task itself, not in sub-tasks.
Critical Path AnalysisThe longest sequential dependency chains that determine wall-clock time.
Batching CandidatesHigh-volume tasks dominated by a single parent. If the parent can batch them,
Duration Distribution
Action Items
Report generated by Utoopack Performance Analysis Agent |
Summary
Fix an HMR race where a source edit made between page load and subscription setup was treated as the initial computation and never reached the browser.
Test Plan
npm run vitest:all(46 Pack tests and 6 Pack Shared tests)cargo clippy --all-targets -- -D warnings --no-depscargo fmtand targeted Biome/Prettier checkscargo test -p pack-tests -- --ignored@utoo/pack@1.5.5in the 19-page EVJSjinni-exploreapp, then inject this branch and verify the same cold-start edit updates in 769 ms with one total main-frame navigation and no page errors