Enhance iOS support with full simulator integration and universal binaries#434
Open
gumaciel wants to merge 25 commits into
Open
Enhance iOS support with full simulator integration and universal binaries#434gumaciel wants to merge 25 commits into
gumaciel wants to merge 25 commits into
Conversation
This commit enables full iOS Simulator support (x86_64 and arm64) for FMOD GDExtension by implementing the following: - SConstruct: Added 'ios_simulator' flag to link correct FMOD libs and support simulator architecture in builds. - Export Plugin: Implemented 'simulator' feature detection to correctly filter and link architecture-specific static libraries (.a) during export. - GitHub Actions: Updated build matrix and added a new 'merge-ios-xcframework' job to automatically create universal XCFrameworks (device + simulator) during release. - Case Sensitivity: Standardized iOS library paths to lowercase 'ios'.
This commit shifts the iOS simulator/device intelligence from the Godot exporter to the build/packaging process. Changes: - src/tools/fmod_editor_export_plugin.cpp: Removed manual 'simulator' feature check; now generically links all static libraries. - .github/workflows/release.yml: Added a new 'lipo' merging step for all FMOD static archives (.a files) to produce universal libraries. - Result: A single Godot export will now correctly support both iOS devices and simulators in a single Xcode project.
…ns to prevent runtime crashes on iOS
…d update gitignore rules
…LIBSUFFIX in SConstruct
Contributor
Author
|
I've created a release tag for testing with these changes, and it's working fine for real devices and the simulator: https://github.com/gumaciel/fmod-gdextension/releases/tag/5.0.12-4.6.2 |
build(ios): integrate dsymutil for dSYM generation in xcframework
There was a space in line 85 before the gdscript block and this was bugging the webpage.
…by CMake + Moved cmake minimum required definition after project definition (utopia-rise#414) * updated .gitignore to not track visual studio solution files * Moved cmake minimum required definition after project definition
…on iOS (utopia-rise#402) * Bindings for `mixerSuspend` and `mixerResume` * Call `FmodServer.mixer_suspend` and `FmodServer.mixer_resume` automatically on iOS * Background muting for all mobile devices --------- Co-authored-by: Benjamin Davis <518044+raggy@users.noreply.github.com>
The build job creates single-arch xcframeworks with dSYMs, but the merge-ios-xcframework job was recreating a new multi-arch xcframework from the raw dylibs without running dsymutil or passing -debug-symbols. This is the actual fix.
|
Is there anything I can do to help get this merged? Do you need help with testing? |
Contributor
Author
|
@AdamGerthel, sorry, but I don't know. Maybe this is a lot of files to be reviewed, I'm waiting @CedNaru or @piiertho to review, thank you But if you want to test, you can use this release on my fork: https://github.com/gumaciel/fmod-gdextension/releases/tag/5.0.13-4.6.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive support for the iOS Simulator and improves the robustness of the
iOS plugin loading system and build pipeline.
Key Changes
both physical iOS devices and simulators.
the symbol might not be present at runtime.
iOS/Simulator environments when static plugins are missing.
were successfully allocated.
and updated the native build action to handle the new architecture.