Repository navigation
Scripts hash themselves, Build on Run is never or always - #1039
Merged
Merged
Conversation
…onfiguration cache can store it
CedNaru
force-pushed
the
improvement/scripts-changed-warning
branch
4 times, most recently
from
November 13, 2026 01:17
8aab00a to
ba9a717
Compare
…ke Build on Run build only never or always
…n Run probe, as a user returning from an IDE does, and edit in the script editor after outside edits
CedNaru
force-pushed
the
improvement/scripts-changed-warning
branch
from
November 13, 2026 01:55
ba9a717 to
43abce9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1032.
Configuration cache fix
compileRegistrarsKotlinfailed to store the configuration cache: the registrar source directory came fromProvider.mapover a task output, which Gradle refuses to evaluate before the task runs. It now usesDirectoryProperty.dir, a location-only provider that still carries the task dependency. The harness turns the configuration cache off, so CI could not catch it; the 3D demo did.Source hashes without a source manager
hashSourceshashes every Kotlin, Java and Scala source of the debug build inside the Godot project, andsource-hashes.jsonbecomes a flatres://path → MD5 map. The task no longer reads.gdignorefiles it did not declare as inputs, which left its output stale and gave it a wrong build cache key.JvmScriptrecords the MD5 of its file when the editor loads or saves it;JvmScriptManagerholds the build hashes and compares.JvmSourceManager, the source roots and the "source directories added, restart the editor" prompt are gone: a script hashes itself wherever it comes from.Build on Run
tab_selected,tab_hovered).Spec C.2.2 is reworded accordingly (maintainer decision).
Tests
build_on_run(reworked around the two options and the node warning; outside edits now give the editor the focus back, as a user returning from an IDE does, which Godot's script editor needs to pick up the change),build_model,reloadandrenamepass. After the toolbar warning was dropped,build_on_runpasses again.