Skip to content

Conversation

@pannadan
Copy link
Collaborator

@pannadan pannadan commented May 4, 2025

seg faulting on a lot of the tests like delete_each and delete_all. Difficult to tell where the issue is coming from because dmesg points to a magic number discrepancy.

@pannadan pannadan requested a review from hayley-leblanc May 4, 2025 03:12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the panic you emailed me about is happening in the inode allocator, specifically in dealloc_ino because IIRC that is called before we deallocate any pages. According to this documentation about the index operation:

/// However be careful: if you try to access an index which isn't in the `Vec`,
/// your software will panic! You cannot do this:
///
/// ```should_panic
/// let v = vec![0, 2, 4, 6];
/// println!("{}", v[6]); // it will panic!
attempting to access an index in a vector that doesn't exist using [] will panic. This is how dealloc_ino tries to update the index of the newly-deallocated inode, so I suspect that the panic occurs because we are trying to access an inode that's beyond the end of the vector. I'm not 100% sure this is the problem, but it's probably a good place to start looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants