Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ansi-width instead of textwrap for width calculation #36

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

tertsdiepraam
Copy link
Member

We don't need all the functionality of textwrap, our own ansi-width is enough.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1522e5f) 53.46% compared to head (8633468) 81.62%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #36       +/-   ##
===========================================
+ Coverage   53.46%   81.62%   +28.15%     
===========================================
  Files           4        4               
  Lines         490      332      -158     
  Branches       80       60       -20     
===========================================
+ Hits          262      271        +9     
+ Misses        209       43      -166     
+ Partials       19       18        -1     
Flag Coverage Δ
macos_latest 80.72% <100.00%> (+27.45%) ⬆️
ubuntu_latest 73.79% <100.00%> (+25.22%) ⬆️
windows_latest 4.51% <0.00%> (+2.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tertsdiepraam
Copy link
Member Author

I'll cut another release after this, which will mean that I can finally get the changes into ls (and probably even eza).

@cakebaker cakebaker merged commit 3e1b70a into uutils:main Feb 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants