Mysql8 entrypoint fix #859
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zen <[email protected]>
Signed-off-by: Zen <[email protected]>
|
Shouldn't the script also attempt to use the provided mysql root password? I'm not sure if this is only meant to run once, if so, it could check that the files it makes at the end exist first. The install wizard also doesn't use the set config so the user has to enter the info again on setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
the entrypoint script breaks for mysql8
2. What does this change do, exactly?
add a check for the version and appropriate updated queries
3. Please link to the relevant issues (if any).