-
Notifications
You must be signed in to change notification settings - Fork 0
Abeer/account designs #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…t/extend-a-family into abeer/account-designs
…t/extend-a-family into abeer/account-designs
Visit the preview URL for this PR (updated for commit 6769a84): https://extendafamily-7613e--pr109-abeer-account-design-3060zq5r.web.app (expires Wed, 19 Mar 2025 23:30:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f8bb7b5cd838ab636347dc54fd0ab08ab3715d31 |
2f4efac
to
2a7c014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, it's looking really good!! 🤩
Summary of comments:
- Create a
PUT /updateMyAccount
user route that applies account updates to the user whose accessToken makes the request (so we don't have a route where any user can update any user...). - After updating the user's account info, we need to make a call to
setLocalStorageObjProperty(AUTHENTICATED_USER_KEY, ...
to update it throughout the frontend. - Instead of using raw hex codes for colours, we want to be using colours from our
theme
(makes it easier for us to tweak our palette and have it be reflected everywhere). - Typography styles should be set using
variant="<style in figma>"
, instead of as individual styles on thesx
object. - Rename
ProfileButton.tsx
->ProfilePicture.tsx
Notion ticket link
Account Designs
Figma File
Implementation description
Steps to test
note its blue for learners but it will be different for each role:
What should reviewers focus on?
Checklist