-
Notifications
You must be signed in to change notification settings - Fork 0
Library Viewing Modals + Context Menu #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -36,7 +209,8 @@ export default function UnitSidebar(props: UnitSideBarProps) { | |||
return ( | |||
<Drawer | |||
sx={{ | |||
width: "20%", | |||
maxWidth: "301px", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set it as 301px because 300px causes a weird horizontal scrollbar situation
Visit the preview URL for this PR (updated for commit 27d145f): https://extendafamily-7613e--pr112-maggie-cud-models-ewdkg6q6.web.app (expires Fri, 04 Apr 2025 01:14:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f8bb7b5cd838ab636347dc54fd0ab08ab3715d31 |
The preview here shows a very strange bug for the unit side bar. If you run this branch locally, it should look normal and according to figma. EDIT: RESOLVED BY 5c97766 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Notion ticket link
Unit Context Menu + CUD Modals
[Figma] https://www.figma.com/design/BVjAeCcvNSYMyaf9Vd9T6M/Extend-a-Family---Primary-Working-File?node-id=986-7956&p=f&t=iJzYmkscoomdnxy4-0
Implementation description
Steps to test
Context menu is correctly implemented
/course
pageExpected result:
Modals are correctly implemented
/course
pageFollow the instructions below to open the implemented modals:
Expected result:
Context menu and modals are only available for administrators
/course
pageExpected result:
What should reviewers focus on?
Checklist