fix: data table changes and updates - #127
Open
nuthanan06 wants to merge 4 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared DataTable and related UI primitives to better match the design system, adding a segmented “subtabs” control, simplifying sorting interactions, and refining hover/toolbar styling. It also documents the DataTable API/usage and improves the component gallery demo for more representative presentation.
Changes:
- Adjust hover/selected styling for table rows and ghost buttons to avoid unintended brand-tinting.
- Add
SubTabsUI component and integrate optional subtabs support intoDataTableToolbar(with updated DataTable types/exports). - Redesign faceted filter menu + simplify sortable column headers, and add a comprehensive DataTable README and updated showcase/demo.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/common/components/ui/table.tsx | Updates table row hover/selected styling tokens. |
| frontend/common/components/ui/subtabs.tsx | Introduces segmented subtabs UI components built on Base UI Tabs. |
| frontend/common/components/ui/index.ts | Re-exports newly added SubTabs components. |
| frontend/common/components/ui/button.tsx | Updates ghost button hover tokens to avoid green tint. |
| frontend/common/components/data-display/index.ts | Exports new DataTable subtabs config type. |
| frontend/common/components/data-display/data-table/README.md | Adds usage documentation for DataTable (sorting, filters, subtabs, states, etc.). |
| frontend/common/components/data-display/data-table/DataTableToolbar.tsx | Adds optional subtabs rendering and refactors toolbar layout. |
| frontend/common/components/data-display/data-table/DataTableFacetedFilter.tsx | Updates filter dropdown UI to match design system component. |
| frontend/common/components/data-display/data-table/DataTableColumnHeader.tsx | Simplifies sorting UX (direct toggle) and removes dropdown/hide behavior. |
| frontend/common/components/data-display/data-table/DataTable.tsx | Wires subtabs prop through to toolbar; tweaks header padding and re-exports types. |
| frontend/CLAUDE.md | Updates internal UI “map” docs to include DataTable/SubTabs and points to the new README. |
| frontend/app/component-gallery/page.tsx | Improves component gallery layout and expands DataTable demo (subtabs + row click). |
| frontend/AGENTS.md | Same as CLAUDE.md updates for agent guidance. |
| backend/requirements.txt | Updates pytest-asyncio version pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation description
Steps to test
What should reviewers focus on?
Checklist
Format for branch, commit, and PR title: docs/GIT.md.