F25/nathanael/onboarding: Complete onboarding task implementation #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthuray
reviewed
Sep 30, 2025
Collaborator
sthuray
left a comment
sthuray
left a comment
There was a problem hiding this comment.
LGTM, I've listed a few things to fix. Other than that, make sure to add screenshots of testing (with edge-cases) using Postman in the future
Collaborator
There was a problem hiding this comment.
Might've accidentally pushed this in
| const { data } = await baseAPIClient.get("team-members/"); | ||
| return data; | ||
| } catch (error: unknown) { | ||
| console.error("Error fetching team members:", error); |
Collaborator
There was a problem hiding this comment.
watch out for linting warnings
matthewd-so
reviewed
Oct 14, 2025
| } | ||
| }; | ||
|
|
||
| // Add a hardcoded team member |
Contributor
There was a problem hiding this comment.
Great understanding of the task
Contributor
|
Try to resolve your conflicts, as this is something you will encounter a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Onboarding Task
Steps to test
docker compose up -dnode migrate uphttp://localhost:3000/team-membersAdd a Jerrybutton.Postman Test Cases:
