Skip to content

Deprecate GetAllTasks Route #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
matthewd-so wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Deprecate GetAllTasks Route #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions backend/typescript/rest/taskRoutes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,30 +11,17 @@
} from "../middlewares/validators/taskValidators";
import TaskService from "../services/implementations/taskService";
import {
TaskResponseDTO,

Check warning on line 14 in backend/typescript/rest/taskRoutes.ts

View workflow job for this annotation

GitHub Actions / run-lint 

'TaskResponseDTO' is defined but never used
ITaskService,
} from "../services/interfaces/taskService";
import { getErrorMessage, NotFoundError } from "../utilities/errorUtils";
import { sendResponseByMimeType } from "../utilities/responseUtil";

Check warning on line 18 in backend/typescript/rest/taskRoutes.ts

View workflow job for this annotation

GitHub Actions / run-lint 

'sendResponseByMimeType' is defined but never used
import { Role } from "../types";

const taskRouter: Router = Router();
taskRouter.use(isAuthorizedByRole(new Set(Object.values(Role))));
const taskService: ITaskService = new TaskService();

/* Get all Tasks */
taskRouter.get("/", async (req, res) => {
const contentType = req.headers["content-type"];
try {
const tasks = await taskService.getTasks();
await sendResponseByMimeType<TaskResponseDTO>(res, 200, contentType, tasks);
} catch (e: unknown) {
await sendResponseByMimeType(res, 500, contentType, [
{ error: getErrorMessage(e) },
]);
}
});

/* Get Task by id */
taskRouter.get("/:id", async (req, res) => {
const { id } = req.params;
Expand Down
Loading