-
Notifications
You must be signed in to change notification settings - Fork 3
Artyom/task template api #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
acfa26e to
3c0bc5a
Compare
|
Looks good to me, database fetching, adding, and filtering all work. I did need to fix some issues with main rebasing. As noted by the author, there were type mismatches btwn frontend and backend, notably with the Another thing to note is that the Notion PR requirements describes an onClick to toggle an edit modal, which was not completed in this PR! It is my understanding that the edit page functionality has already been completed, so I'll prolly just pull it up on click. |
Akishai18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all LGTM however the page is missing the pagination component specified in the ticket. The Task Management page currently doesn’t render the shared component like User Management does.
Akishai18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, this all looks good.
Notion ticket link
Ticket Name
Steps to test
/admin/tasksWhat should reviewers focus on?
Notes
Checklist