Skip to content

Artyom/task template api#161

Merged
Akishai18 merged 8 commits intomainfrom
artyom/task-template-api
Feb 7, 2026
Merged

Artyom/task template api#161
Akishai18 merged 8 commits intomainfrom
artyom/task-template-api

Conversation

@Artyom-G
Copy link
Member

@Artyom-G Artyom-G commented Nov 11, 2025

Notion ticket link

Ticket Name

Steps to test

  1. Go to /admin/tasks
  2. Create a new task
  3. Verify that the new task is added
  4. Verify that the search works (based on the name and description)
  5. Verify that the category filters work
image

What should reviewers focus on?

  • Functionality truly works

Notes

  • The backend and frontend types did not match so I had to change the frontend types to match the backend
  • This created errors that should be fixed now, but if encountered then the frontend should be matched to the backend

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Artyom-G Artyom-G requested a review from sthuray November 11, 2025 00:41
@amanduhhhh amanduhhhh force-pushed the artyom/task-template-api branch from acfa26e to 3c0bc5a Compare January 30, 2026 19:48
@amanduhhhh amanduhhhh assigned amanduhhhh and unassigned amanduhhhh Jan 30, 2026
@amanduhhhh
Copy link
Contributor

amanduhhhh commented Jan 30, 2026

Looks good to me, database fetching, adding, and filtering all work.

I did need to fix some issues with main rebasing. As noted by the author, there were type mismatches btwn frontend and backend, notably with the Task interface in TaskTypes.ts. The author dealt with it by changing name to taskName, while someone in main created the TaskTemplateResponseDTO and a conversion function in TaskTemplateAPIClient.ts. I kept the latter.

Another thing to note is that the Notion PR requirements describes an onClick to toggle an edit modal, which was not completed in this PR!

It is my understanding that the edit page functionality has already been completed, so I'll prolly just pull it up on click.

@Akishai18 Akishai18 self-requested a review February 6, 2026 03:11
Akishai18
Akishai18 requested changes Feb 6, 2026
View reviewed changes
Copy link
Collaborator

@Akishai18 Akishai18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM however the page is missing the pagination component specified in the ticket. The Task Management page currently doesn’t render the shared component like User Management does.

@amanduhhhh amanduhhhh requested a review from Akishai18 February 6, 2026 23:46
@amanduhhhh amanduhhhh mentioned this pull request Feb 7, 2026
Merged
4 tasks
Akishai18
Akishai18 approved these changes Feb 7, 2026
View reviewed changes
Copy link
Collaborator

@Akishai18 Akishai18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this all looks good.

@Akishai18 Akishai18 added this pull request to the merge queue Feb 7, 2026
Merged via the queue into main with commit 327d850 Feb 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akishai18 Akishai18 Akishai18 approved these changes

@sthuray sthuray Awaiting requested review from sthuray

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Artyom-G @amanduhhhh @Akishai18