Artyom - Added Proper Frontend User Invitations #165
Draft
Conversation
matthewd-so
approved these changes
Nov 25, 2025
Contributor
matthewd-so
left a comment
matthewd-so
left a comment
There was a problem hiding this comment.
LGTM just fix linting errors
sthuray
requested changes
Dec 18, 2025
Collaborator
sthuray
left a comment
sthuray
left a comment
There was a problem hiding this comment.
Ticket requirements not fulfilled, marked as draft.
| return res.status(400).send(getApiValidationError("role", "string")); | ||
| } | ||
| if (!validatePrimitive(req.body.colorLevel, "integer")) { | ||
| // put a false here, not sure what a color level is because the backend literally sets it to 1 on creation anyway |
| res.status(404).send(getErrorMessage(error)); | ||
| } else { | ||
| res.status(500).json({ error: getErrorMessage(error) }); | ||
| await userService.deleteUserByEmail(req.body.email); |
Collaborator
There was a problem hiding this comment.
This behaviour wasn't part of the ticket requirements, can you explain this decision?
Note: invite user endpoint does NOT create a user.
| id: number; | ||
| firstName: string; | ||
| lastName: string; | ||
| name: string; |
Collaborator
There was a problem hiding this comment.
What is the purpose of this change?
Did you check whether it causes any regressions?
VictorChan880
force-pushed
the
F25/artyom/invite-user
branch
from
0135b3c to
ad20aea
Compare
Collaborator
|
@VictorChan880 Fix merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Ticket Name
Implementation description
Steps to test
backend/authRoutes.tsxand make the invite function throw an error (throw "bingus";) right before theres.status(204).send();line. This will always fail the invitation and you can see that the newly created user is successfully deleted (check the postgres)What should reviewers focus on?
Checklist