Merged
Conversation
sthuray
previously requested changes
Nov 27, 2025
Collaborator
sthuray
left a comment
There was a problem hiding this comment.
Overall, LGTM (haven't tested yet). Left a few minor nitpicks to change.
backend/typescript/migrations/2025.11.24T20.00.00.create-recurrence-tasks.ts
Show resolved
Hide resolved
backend/typescript/migrations/2025.11.24T20.00.00.create-recurrence-tasks.ts
Outdated
Show resolved
Hide resolved
Akishai18
approved these changes
Feb 5, 2026
Collaborator
Akishai18
left a comment
There was a problem hiding this comment.
LGTM - Requirements and Fixes Fulfilled
Requested changes addressed in latest commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Create Recurrence Task Table
Implementation description
Added a new migration to create the recurrence_tasks table to support Weekly, Biweekly, Monthly, and Annually recurring tasks.
Added RecurrenceTask model with fields: task_id, days, cadence, end_date, and exclusions.
Updated Task model to include a @hasone relationship to RecurrenceTask so recurrence details can be retrieved via include: ["recurrence"]
Steps to test
Copy the returned id (call it TEMPLATE_ID).
Replace TEMPLATE_ID with the value from Step 1.
Copy the returned id (call it TASK_ID).
Replace TASK_ID with the value from Step 2.
If this returns a row, the recurrence was created correctly and can be retrieved via task.recurrence.
Checklist