Skip to content

Conversation

@zeukyr
Copy link

@zeukyr zeukyr commented Feb 11, 2026

Notion ticket link

Create Add Pet Form

Implementation description

  • Created AddPetForm component by repurposing the existing EditPetForm
  • Added QuitEditingModal component to warn users about unsaved changes when navigating away, which navigates back to pet list (home page) on "Leave" and closes on "Keep Editing"
  • Added AddPetModal component to confirm adding a pet, which closes popup on "Cancel"

Steps to test

  1. Navigate to /add-pet-form route
  2. Verify clicking "Back to pet list" button causes a modal to appear -"Leave" should navigate to pet list page and "Keep Editing" should close the modal
  3. Fill out page 1 fields without all requirements to verify that shows validation errors
  4. Fill required fields and click "Next" - should navigate to page 2
  5. Verify clicking "Save" causes a modal to appear, and "Cancel" closes it

What should reviewers focus on?

  • QuitEditingModal behavior and form validation for required field are correct

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Collaborator

@Akishai18 Akishai18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. But fix AddPetForm to use pet default profile photo instead of user default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants