Skip to content

Create login frontend page#53

Merged
aliicezhao merged 14 commits intomainfrom
create-login-frontend
Feb 12, 2025
Merged

Create login frontend page#53
aliicezhao merged 14 commits intomainfrom
create-login-frontend

Conversation

@aliicezhao
Copy link
Contributor

Notion ticket link

Login Page

Implementation description

  • Modified the Login to now display an email and password field, with validation
  • Uses Redirect on success to go to pets
  • If viewed on a phone in landscape, it becomes scrollable

Steps to test

  1. Go to localhost:3000/login, make sure data is cleared
  2. Both fields should throw error if invalid/empty field
  3. On success, should redirect to /pets

What should reviewers focus on?

  • Logging in and redirectly correctly
  • Throwing errors correctly
  • Any coding style/visual things that look off
  • Unlimited attempts at logging in?

Checklist

  • [ x] My PR name is descriptive and in imperative tense
  • [ x] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • [ x] I have run the appropriate linter(s)
  • [ x] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Scrrenshots

Screenshot 2024-11-27 at 12 21 10 AM Screenshot 2024-11-27 at 12 21 31 AM Screenshot 2024-11-27 at 12 21 52 AM Screenshot 2024-11-27 at 12 22 18 AM

Copy link
Collaborator

@sthuray sthuray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Login and error checking work properly. The only thing I'd say is that you'll need to handle some merge conflicts after Trinity's PR is merged in since there's some overlap here

@aliicezhao aliicezhao added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 00b00f3 Feb 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants