Skip to content

S24/sayi/connect email form#56

Merged
JustinScitech merged 3 commits intomainfrom
S24/sayi/connect-email-form
Jan 31, 2025
Merged

S24/sayi/connect email form#56
JustinScitech merged 3 commits intomainfrom
S24/sayi/connect-email-form

Conversation

@sthuray
Copy link
Collaborator

@sthuray sthuray commented Dec 30, 2024

Notion ticket link

Connecting Invite User Flow to Frontend

Implementation description

  • Connected calls to frontend by creating a user and then inviting them (on click of Add User button)
  • Fix to update user to ACTIVE status after successful link-based login
  • Quick change to the error message handling in the UserManagementPage.tsx / UserAPIClient

Steps to test

  1. Try creating a new user and inviting them
Screenshot 2024-12-29 at 7 17 06 PM 2. After clicking on sign-in link and signing in, ensure that status is ACTIVE (after page refresh) Screenshot 2024-12-29 at 7 28 51 PM

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@sthuray sthuray requested a review from JustinScitech January 31, 2025 01:44
@shencynthia shencynthia self-requested a review January 31, 2025 02:44
Copy link
Contributor

@JustinScitech JustinScitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good

@JustinScitech JustinScitech added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 271bf86 Jan 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants