Skip to content

Refactor and standardize#69

Merged
shencynthia merged 6 commits intomainfrom
W25/cynthia/refactor-and-standerize
Mar 4, 2025
Merged

Refactor and standardize#69
shencynthia merged 6 commits intomainfrom
W25/cynthia/refactor-and-standerize

Conversation

@shencynthia
Copy link
Contributor

@shencynthia shencynthia commented Mar 2, 2025

Notion ticket link

Refactor and standardize

Implementation description

In hopes of making the frontend code base cleaner for future terms, I did some refactoring.

  • Update routes to be kebab-case
  • Move images and pages out of src/components

Steps to test

  1. test out that existing pages did not break

What should reviewers focus on?

  • do we agree with the refactors? will this make it easier to navigate the frontend code?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Contributor

@trinity-y trinity-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the routes 👍

Copy link
Contributor

@tonyqiu123 tonyqiu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export const DISPLAY_ENTITY_PAGE = "/entity";
export const DISPLAY_SIMPLE_ENTITY_PAGE = "/simpleEntity";

i tested each route and they all work except for the two above. i'm not familiar with these routes but if they don't need to be working, then this PR LGTM

@shencynthia
Copy link
Contributor Author

export const DISPLAY_ENTITY_PAGE = "/entity"; export const DISPLAY_SIMPLE_ENTITY_PAGE = "/simpleEntity";

i tested each route and they all work except for the two above. i'm not familiar with these routes but if they don't need to be working, then this PR LGTM

@tonyqiu123 These are both from startercode, not used in our app!

@shencynthia shencynthia added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit a5957c4 Mar 4, 2025
1 check passed
@shencynthia shencynthia deleted the W25/cynthia/refactor-and-standerize branch May 3, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants