ranking forms #47
Merged
ranking forms #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YashK2005
force-pushed
the
llsc-74-ranking-forms
branch
from
295f7e1 to
1e8cf69
Compare
…for options; minor migration formatting
…..5 unique); unit tests
…might need to check to make sure that we are showing the correct options for all cases with pms, we shoudl ahve some status thing that controls when the ranking form should be shown after login vs the current behaviour of always navigating to the intake form (even when its already been submitted)
…eed to add logic for having some sort of status taht determines when to show the intake form, when to show the intake thank you form, when to show ranking form, and when to show ranking thank you form after login as well as gating certain pages when not authed or wrong status
YashK2005
force-pushed
the
llsc-74-ranking-forms
branch
from
1e8cf69 to
e9dd5eb
Compare
…tchikng info about the logged in user. added protectedroutes that allow us to block certain types of viewers from viewing certain pages so particiapnts can't access the volunteer intake form and vice versa. added a basic unauthorized page to go with this (we can improve this styling/look later) as well as a basic loading skeleton (which can also potentially be improved visually later). also updated teh intake form thank you screen to match the figma text. only thing left for forms i think is the logic for showing the user certain pages/forms based on what they've already copmleted and what step the admin has put them in. this i think could go in a separate pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
llsc-74-ranking forms
Implementation description
This PR completes the ranking forms on both the frontend and backend. It also includes a migration to update the ranking_preferences schema so that we can store experiences/treatments rather than just qualities, and so that we can also keep track of whether the scope of the preference selected is for the volunteer or the volunteer's loved one (which is needed for cases where the user is a caregiver requesting a caregiver volunteer). This should hopefully make getting the ranking preferences easier for the matching part.
A bunch of frontend improvements as well. The main one is the new protected page component which allows us to restrict certain types of users from viewing certain pages (so that volunteers can't access the participant intake or ranking form and participants can't access the volunteer intake form, etc.).
To complete the forms, we still need to do the secondary application form for volunteers. I think the backend has been started in another branch but I don't think we've started the frontend yet.
We also need the logic for controlling what should be shown to users when they login for both participants and volunteers (eg. should it be the intake form, intake thank you note, ranking form, ranking thank you note, or dashboard). This can probably go in a separate PR later? We'll probably need some new endpoints for allowing admins to move users between stages and potentially schema changes (haven't thought about this in much detail yet).
I think some minor styling improvements can be made to better match the figma designs, as well as making sure our forms look good on mobile as well.
Steps to test
What should reviewers focus on?
Checklist