Skip to content

add claim absence#105

Merged
ChinemeremChigbo merged 5 commits intomainfrom
evelina/claim-absence
Apr 11, 2025
Merged

add claim absence#105
ChinemeremChigbo merged 5 commits intomainfrom
evelina/claim-absence

Conversation

@135ze
Copy link
Collaborator

@135ze 135ze commented Apr 2, 2025

Notion Ticket

Claim Absence

Summary & Review Focus

  • created claimAbsence route
  • added confirmation modal before claim
  • added thanks modal for claim confirmation
  • edited dates to show "-th", "-st", etc

Testing Instructions

  1. Edit your id so the changes are properly saved as a "real" user (eg in useUserData, return id: fetchedUserData?.id ?? not 0)
  2. go to /calendar and click on an absence, then fill absence
  3. ensure modal appears matching figma (https://www.figma.com/design/bTjr8nLilr2ps62RpxNAmb/Final-Designs?node-id=4-27675&m=dev)
    image
  4. on confirm, the absence in the calendar background should switch to show "Filled" (seen in background for may 15), and appear in "my absences" tab of calendar as well.
    image
    image

Checklist

  • PR title is descriptive and in imperative tense
  • Commit messages are descriptive, atomic, and follow best practices
  • Linter(s) have been run
  • Requested reviews from the PL and relevant team members

@vercel
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 3:49pm

@135ze 135ze marked this pull request as ready for review April 5, 2025 18:05
@135ze 135ze requested review from a team, ChinemeremChigbo and anthonytecsa and removed request for a team April 5, 2025 18:05
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChinemeremChigbo ChinemeremChigbo merged commit dd2ec5b into main Apr 11, 2025
1 check passed
ChinemeremChigbo added a commit that referenced this pull request Apr 11, 2025
(Merge #105 first) Show warning on Absence Conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants