Skip to content

Fix File Upload for Absences#108

Merged
ChinemeremChigbo merged 8 commits intomainfrom
david/fix-file-upload-for-events
Apr 11, 2025
Merged

Fix File Upload for Absences#108
ChinemeremChigbo merged 8 commits intomainfrom
david/fix-file-upload-for-events

Conversation

@ludavidca
Copy link
Collaborator

@ludavidca ludavidca commented Apr 2, 2025

Notion Ticket

Upload PDF Component in LessonPlanDisplay

Summary & Review Focus

  • Implemented Updated Behavior to Lesson Plan Submission
  • Implemented File Upload functionality
  • Added Buttons for Swapping, which pop up when file is added
  • Implemented changes to structure of import form (to allow fileupload component to be reused)
  • Additional quality of life improvements

NOTE: SENDING A PATCH REQUEST IS NOT COMPLETED YET. This can be completed by me once the API endpoints are established 😄

Testing Instructions

  1. run docker compose up --build
  2. create a absence with no lesson plan uploaded
  3. Upload lesson plan by clicking on the event and to drag and drop
  4. Check in GDrive or console for file details

Checklist

  • PR title is descriptive and in imperative tense
  • Commit messages are descriptive, atomic, and follow best practices
  • Linter(s) have been run
  • Requested reviews from the PL and relevant team members

@vercel
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 9:49pm

@ludavidca ludavidca requested review from ChinemeremChigbo, VJagiasi and kenzysoror and removed request for VJagiasi April 2, 2025 03:28
@ChinemeremChigbo ChinemeremChigbo marked this pull request as draft April 2, 2025 19:53
@ludavidca ludavidca marked this pull request as ready for review April 5, 2025 16:05
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChinemeremChigbo ChinemeremChigbo merged commit b7c2dab into main Apr 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants