Skip to content

Edit Notes in AbsenceDetails#109

Merged
ChinemeremChigbo merged 7 commits intomainfrom
kenzy/edit-notes
Apr 11, 2025
Merged

Edit Notes in AbsenceDetails#109
ChinemeremChigbo merged 7 commits intomainfrom
kenzy/edit-notes

Conversation

@kenzysoror
Copy link
Member

@kenzysoror kenzysoror commented Apr 5, 2025

Notion Ticket

Edit Notes in AbsenceDetails

Summary & Review Focus

  • Editable text box appears when the editNotes button in AbsenceDetails is clicked
    • Initially populated with the absence's current notes
    • Minimum height = current notes height + 33px (design matching)
    • User's cursor is placed at the end of the notes
  • "Cancel" and "Save Changes" buttons

Related Future Work

  • "Save Changes" button should update the edited absence with the new notes (requires the WIP Edit Absence API)

Testing Instructions

  1. Toggle to teacher view
  2. Declare an absence with notes + click on the editNotes button
    a. Ensure the current notes + a 33px gap are visible
    b. Ensure your cursor is at the end of the current notes
    c. Ensure you can type in the box
    d. Ensure both the "Cancel" and "Save Changes" buttons close the text box
  3. Declare an absence without notes + click on the editNotes button
    a. Ensure a line with your cursor + a 33 px gap are visible
    b. Ensure you can type in the box
    c. Ensure both the "Cancel" and "Save Changes" buttons close the text box

image

Checklist

  • PR title is descriptive and in imperative tense
  • Commit messages are descriptive, atomic, and follow best practices
  • Linter(s) have been run
  • Requested reviews from the PL and relevant team members

@vercel
Copy link

vercel bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 5:52pm

Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChinemeremChigbo ChinemeremChigbo merged commit 89fc639 into main Apr 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants