Skip to content

Add pressed state to email subs #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

Conversation

ColinToft
Copy link
Contributor

@ColinToft ColinToft commented Apr 13, 2025

Notion Ticket

Ticket Name

Summary & Review Focus

(Sorry for the lengthy PR)

Fixes nit:

  • There is no press state in the email subscriptions dropdown
  • I actually wasn't sure exactly what colour this should be based on the design, so I chose neutral gray 300 to match the year selection dropdown.

Testing Instructions

Checklist

  • PR title is descriptive and in imperative tense
  • Commit messages are descriptive, atomic, and follow best practices
  • Linter(s) have been run
  • Requested reviews from the PL and relevant team members

@ColinToft ColinToft self-assigned this Apr 13, 2025
Copy link

vercel bot commented Apr 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 4:55pm

@ColinToft ColinToft requested a review from Copilot April 13, 2025 18:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/components/dashboard/user_management/EditableSubscriptionsCell.tsx:346

  • [nitpick] Consider adding an inline comment to explain why 'neutralGray.300' was chosen for the pressed state, ensuring future maintainers understand the design rationale.
_active={{ bg: 'neutralGray.300' }}

Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChinemeremChigbo ChinemeremChigbo merged commit fcf74c9 into main Apr 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants