Skip to content

Refactor code for calendar event retrieval and ICS generation#59

Merged
ColinToft merged 1 commit intomainfrom
colin/calendar-api-changes
Feb 12, 2025
Merged

Refactor code for calendar event retrieval and ICS generation#59
ColinToft merged 1 commit intomainfrom
colin/calendar-api-changes

Conversation

@ColinToft
Copy link
Contributor

@ColinToft ColinToft commented Feb 5, 2025

Notion ticket link

N/A

Ticket Name

Implementation description

  • Moves some functions around that are common to calendar/ics file generation
  • No functional change

Steps to test

  1. Make sure calendar (/calendar) still works and shows events
  2. Make sure ics file download (/ics) still works

What should reviewers focus on?

  • Let me know if this structure is reasonable (I'm not sure where to place common files in a next.js repo)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 2:02am

@ColinToft ColinToft force-pushed the colin/calendar-api-changes branch from 2a2dcdd to 5ef0bfa Compare February 5, 2025 02:01
@ColinToft ColinToft requested review from a team, ChinemeremChigbo and daniel-su1 and removed request for a team February 5, 2025 02:03
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@daniel-su1 daniel-su1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ColinToft ColinToft merged commit 5053b35 into main Feb 12, 2025
3 checks passed
@ColinToft ColinToft deleted the colin/calendar-api-changes branch February 12, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants