-
Notifications
You must be signed in to change notification settings - Fork 4
Confirm Absence Modals and Toasts #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces custom modal and toast components for confirming and displaying absence actions. Key changes include:
- Removal of the inline confirmation modal in InputForm and replacement with the reusable ConfirmAbsenceModal.
- Addition of the ClaimAbsenceToast component for displaying toast messages related to absence claims.
- Integration of the new components into InputForm and AbsenceDetails for a consistent user experience.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/components/InputForm.tsx | Replaces inline modal with ConfirmAbsenceModal and integrates theme usage. |
src/components/ConfirmAbsenceModal.tsx | New component for handling absence confirmation with conditional UI. |
src/components/ClaimAbsenceToast.tsx | New component for rendering toasts for absence claim feedback. |
src/components/AbsenceDetails.tsx | Integrates ClaimAbsenceToast for toast confirmations on absence claim. |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion Ticket
[Ticket Name
](https://www.notion.so/uwblueprintexecs/cbdf017805914bc18232d710f54c8d6e?v=afe5871b5c7c4f78830085dba067a00c&p=1ab10f3fb1dc8012861bfac817e4ca63&pm=s)
Summary & Review Focus
Added some custom modals for add absence confirmation and toasts for claiming
Testing Instructions
Checklist