Skip to content

Confirm Absence Modals and Toasts #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 16, 2025
Merged

Confirm Absence Modals and Toasts #98

merged 15 commits into from
Apr 16, 2025

Conversation

anthonytecsa
Copy link
Contributor

Notion Ticket

[Ticket Name
](https://www.notion.so/uwblueprintexecs/cbdf017805914bc18232d710f54c8d6e?v=afe5871b5c7c4f78830085dba067a00c&p=1ab10f3fb1dc8012861bfac817e4ca63&pm=s)

Summary & Review Focus

Added some custom modals for add absence confirmation and toasts for claiming

Testing Instructions

  1. Try the claim absence button for the toast confirmations, the success and failiure is hardcoded right now in AbsenceDetails.tsx
  2. Try the different confirmation modals for adding an absence (no lesson plan, within 2 weeks combinations)

Checklist

  • PR title is descriptive and in imperative tense
  • Commit messages are descriptive, atomic, and follow best practices
  • Linter(s) have been run
  • Requested reviews from the PL and relevant team members

Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 2:18am

@anthonytecsa anthonytecsa requested review from Copilot, ChinemeremChigbo, a team and ColinToft and removed request for a team March 29, 2025 23:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces custom modal and toast components for confirming and displaying absence actions. Key changes include:

  • Removal of the inline confirmation modal in InputForm and replacement with the reusable ConfirmAbsenceModal.
  • Addition of the ClaimAbsenceToast component for displaying toast messages related to absence claims.
  • Integration of the new components into InputForm and AbsenceDetails for a consistent user experience.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/components/InputForm.tsx Replaces inline modal with ConfirmAbsenceModal and integrates theme usage.
src/components/ConfirmAbsenceModal.tsx New component for handling absence confirmation with conditional UI.
src/components/ClaimAbsenceToast.tsx New component for rendering toasts for absence claim feedback.
src/components/AbsenceDetails.tsx Integrates ClaimAbsenceToast for toast confirmations on absence claim.

@ChinemeremChigbo ChinemeremChigbo merged commit adfc2a5 into main Apr 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants