[INTW26] add endpoint for setting reviewerHasConflict to true#110
Merged
[INTW26] add endpoint for setting reviewerHasConflict to true#110
Conversation
7baea9d to
4b3d6e7
Compare
SaqAsh
approved these changes
Feb 8, 2026
Collaborator
SaqAsh
left a comment
There was a problem hiding this comment.
LGTM, just fix some of the small nitpicks I had, and make sure that when you touch a file that you format the imports using alt shift/option o command so we have clean files :)
backend/typescript/services/implementations/reviewPageService.ts
Outdated
Show resolved
Hide resolved
backend/typescript/services/implementations/reviewPageService.ts
Outdated
Show resolved
Hide resolved
backend/typescript/services/implementations/reviewPageService.ts
Outdated
Show resolved
Hide resolved
backend/typescript/services/implementations/reviewPageService.ts
Outdated
Show resolved
Hide resolved
backend/typescript/services/implementations/reviewPageService.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Implement Report Conflict Feature
Implementation description
reportReviewConflictmutation resolver and service to set columnreviewerHasConflicttotruefor a target row in tablereviewed_applicant_recordsSteps to test
createReviewedApplicantRecordwith some valid inputapplicantRecordIdandreviewerId, confirm that columnreviewerHasConflictfor thatapplicantRecordIdandreviewerIdin tablereviewed_applicant_recordsisfalsereportReviewConflictwith the same inputapplicantRecordIdandreviewerId, confirm that columnreviewerHasConflictfor the same row changed totrueWhat should reviewers focus on?
Checklist