Skip to content

[INTW26] add endpoint for setting reviewerHasConflict to true#110

Merged
chene0 merged 4 commits intomainfrom
ethanchen/implement-report-conflict-feature
Feb 11, 2026
Merged

[INTW26] add endpoint for setting reviewerHasConflict to true#110
chene0 merged 4 commits intomainfrom
ethanchen/implement-report-conflict-feature

Conversation

@chene0
Copy link
Contributor

@chene0 chene0 commented Feb 6, 2026

Notion ticket link

Implement Report Conflict Feature

Implementation description

  • Add reportReviewConflict mutation resolver and service to set column reviewerHasConflict to true for a target row in table reviewed_applicant_records

Steps to test

  1. Call mutation createReviewedApplicantRecord with some valid input applicantRecordId and reviewerId, confirm that column reviewerHasConflict for that applicantRecordId and reviewerId in table reviewed_applicant_records is false
  2. Call mutation reportReviewConflict with the same input applicantRecordId and reviewerId, confirm that column reviewerHasConflict for the same row changed to true

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@chene0 chene0 requested a review from mxc-maggiechen February 7, 2026 23:03
@chene0 chene0 force-pushed the ethanchen/implement-report-conflict-feature branch from 7baea9d to 4b3d6e7 Compare February 7, 2026 23:55
@chene0 chene0 marked this pull request as ready for review February 7, 2026 23:59
@mxc-maggiechen mxc-maggiechen requested a review from SaqAsh February 8, 2026 00:46
Copy link
Collaborator

@SaqAsh SaqAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix some of the small nitpicks I had, and make sure that when you touch a file that you format the imports using alt shift/option o command so we have clean files :)

Copy link
Contributor

@mxc-maggiechen mxc-maggiechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chene0 chene0 merged commit d7cfc20 into main Feb 11, 2026
1 check passed
@chene0 chene0 deleted the ethanchen/implement-report-conflict-feature branch February 11, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants