Merged
Conversation
mxc-maggiechen
approved these changes
Jun 21, 2025
Contributor
mxc-maggiechen
left a comment
There was a problem hiding this comment.
Works great! thanks so much for doing so much work on this 👍 I think the workflow error might be a Github problem, but maybe look into it a bit? If we can't resolve it we can merge it in by bypassing permissions
Comment on lines
136
to
153
| export const EngineeringPositionTitles = [ | ||
| "Project Lead", | ||
| "Developer", | ||
| "VP Engineering", | ||
| ] as const; | ||
| export const DesignPositionTitles = [ | ||
| "Designer", | ||
| "VP Design", | ||
| "Graphic Designer", | ||
| ] as const; | ||
| export const ProductPositionTitles = ["Product Manager", "VP Product"] as const; | ||
| export const CommunityPositionTitles = [ | ||
| "President", | ||
| "VP Scoping", | ||
| "VP Talent", | ||
| "VP Finance", | ||
| "Director Lead", | ||
| "Internal Director", | ||
| "External Director", | ||
| "Content Strategist", | ||
| ] as const; |
Contributor
There was a problem hiding this comment.
if you have time, maybe create a enum for all position titles to prevent misspelling
3ab55c9 to
ad83350
Compare
ad83350 to
836cea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Notion ticket link
Create User, Admin, and Role Models + Migration Files
Implementation description
adminandpositionpositionfield touserSteps to test
docker exec recruitment_tools_backend node migrate up.adminsandpositionsare seeded with the provided data in the migration file, and check thatusersnow has apositioncolumn (I left this nullable for backward compatibility - existing records don't have the field).What should reviewers focus on?
Checklist