-
Notifications
You must be signed in to change notification settings - Fork 1
[INTF25] Build filter for fetch review dashboard query #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7ddb85e to
b4f17ba
Compare
ce4d304 to
1b0f5a7
Compare
# Conflicts: # backend/typescript/graphql/resolvers/reviewDashboardResolvers.ts # backend/typescript/graphql/types/reviewDashboardType.ts # backend/typescript/services/implementations/reviewDashboardService.ts # backend/typescript/services/interfaces/IReviewDashboardService.ts
9b0c437 to
80878d6
Compare
| if (filter.role) { | ||
| if (filter.role.toString() === "int_dir") { | ||
| exp.push({ position: { [Op.eq]: "Internal Director" } }); | ||
| } else if (filter.role.toString() === "ext_dir") { | ||
| exp.push({ position: { [Op.eq]: "External Director" } }); | ||
| } else if (filter.role.toString() === "pres") { | ||
| exp.push({ position: { [Op.eq]: "President" } }); | ||
| } else if (filter.role.toString() === "vpe") { | ||
| exp.push({ position: { [Op.eq]: "VP Engineering" } }); | ||
| } else if (filter.role.toString() === "vpd") { | ||
| exp.push({ position: { [Op.eq]: "VP Design" } }); | ||
| } else if (filter.role.toString() === "vpp") { | ||
| exp.push({ position: { [Op.eq]: "VP Product" } }); | ||
| } else if (filter.role.toString() === "vpt") { | ||
| exp.push({ position: { [Op.eq]: "VP Talent" } }); | ||
| } else if (filter.role.toString() === "vp_ext") { | ||
| exp.push({ position: { [Op.eq]: "VP External" } }); | ||
| } else if (filter.role.toString() === "vp_int") { | ||
| exp.push({ position: { [Op.eq]: "VP Internal" } }); | ||
| } else if (filter.role.toString() === "vp_comms") { | ||
| exp.push({ position: { [Op.eq]: "VP Community" } }); | ||
| } else if (filter.role.toString() === "vp_scoping") { | ||
| exp.push({ position: { [Op.eq]: "VP Scoping" } }); | ||
| } else if (filter.role.toString() === "vp_finance") { | ||
| exp.push({ position: { [Op.eq]: "VP Finance" } }); | ||
| } else if (filter.role.toString() === "pm") { | ||
| exp.push({ position: { [Op.eq]: "Project Manager" } }); | ||
| } else if (filter.role.toString() === "pl") { | ||
| exp.push({ position: { [Op.eq]: "Project Lead" } }); | ||
| } else if (filter.role.toString() === "design_mentor") { | ||
| exp.push({ position: { [Op.eq]: "Design Mentor" } }); | ||
| } else if (filter.role.toString() === "graphic_design") { | ||
| exp.push({ position: { [Op.eq]: "Graphic Design" } }); | ||
| } else if (filter.role.toString() === "product_design") { | ||
| exp.push({ position: { [Op.eq]: "Product Design" } }); | ||
| } else if (filter.role.toString() === "uxr") { | ||
| exp.push({ position: { [Op.eq]: "User Researcher" } }); | ||
| } else if (filter.role.toString() === "dev") { | ||
| exp.push({ position: { [Op.eq]: "Developer" } }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you feel if we just pass in a position string instead of making GraphQL guard with an enum. if we can't find anything entries with matching position string, we just return empty array. just looking at this term, we added i think 2 new positions, i think doing it without this enum check would make it easier to add new positions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we can also do multi-select positions for filtering? i think i see that in the design right now, so it would be good to have that option if it's not too bad to implement 🙏
ericahan22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! But maybe remove the .idea files
Notion ticket link
Ticket Name
Implementation description
Steps to test
applicantsandapplicant_records, and filter for that record in the GraphQL query. Below is the query template.What should reviewers focus on?
Checklist