[INTF25] Build Mutator to Create Reviewed Applicant Record

[isabellehuangg]

Notion ticket link

Ticket Name

Implementation description

• Added service functions under that update using Sequelize for creating and deleting one/multiple review records
• Created a GraphQL resolver file and types
• Imported new resolver and types into backend/typescript/graphql/index.ts
• Migration added to add createdAt and updatedAt columns to reviewed_applicant_records DB

In the graphQL playground, I ran the following:

1. Single create:

mutation {
  createReviewedApplicantRecord(
    input: {
      applicantRecordId: "0dae4a96-df1b-4e8d-9555-cd98335cb9c4",
      reviewerId: 1,
      review: {
        passionFSG: 5,
        teamPlayer: 4,
        desireToLearn: 5,
        skill: 3,
        skillCategory: INTERMEDIATE
      },
      status: "PENDING"
    }
  ) {
    applicantRecordId
    reviewerId
    review {
      passionFSG
      teamPlayer
      desireToLearn
      skill
      skillCategory
    }
    status
    score
    reviewerHasConflict
  }
}

2. Bulk create: This tests null fields for status and review too

mutation {
  bulkCreateReviewedApplicantRecord(
    inputs: [
      { 
        applicantRecordId: "0bdb339f-4321-4bd4-9cb7-6b9dcde5771a", 
        reviewerId: 2,
        review: {
        	passionFSG: 5,
        },
        status: "PENDING"
      },
      { 
        applicantRecordId: "0bdb339f-4321-4bd4-9cb7-6b9dcde5771a", 
        reviewerId: 3,
      }
    ]
  ) {
    applicantRecordId
    reviewerId
    review {
      passionFSG
      teamPlayer
      desireToLearn
      skill
      skillCategory
    }
    status
    score
    reviewerHasConflict
  }
}

3. Single Delete

mutation {
  deleteReviewedApplicantRecord(
    input: {
      applicantRecordId: "0bdb339f-4321-4bd4-9cb7-6b9dcde5771a",
      reviewerId: 3 
    }
  ) {
    applicantRecordId
    reviewerId
    review {
      passionFSG
      teamPlayer
      desireToLearn
      skill
      skillCategory
    }
    status
  }
}

4. Bulk delete

mutation {
  bulkDeleteReviewedApplicantRecord(
    inputs:[
      {
        applicantRecordId:"0dae4a96-df1b-4e8d-9555-cd98335cb9c4"
        reviewerId: 1
      },
      {
        applicantRecordId:"0bdb339f-4321-4bd4-9cb7-6b9dcde5771a",
        reviewerId: 2
      }
    ]
  ) {
    applicantRecordId
    reviewerId
    review {
      passionFSG
      teamPlayer
      desireToLearn
      skill
      skillCategory
    }
    status
  }
}

What should reviewers focus on?

• There was no previous support that I could find for JSON fields, so lines 43-67 of backend/typescript/graphql/index.ts

Checklist

• My PR name is descriptive and in imperative tense
• My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
• I have run the appropriate linter(s)
• I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

[mxc-maggiechen]

nit: just to keep with naming conventions, this type should be DeleteReviewedApplicantRecord

[mxc-maggiechen]

DeleteReviewedApplicantRecordDTO

[mxc-maggiechen]

I think this is legacy code I deleted in another PR... would you mind merging to main to get rid of this LOL, sorry I forgot everyone to pull main when I merged that PR in

[mxc-maggiechen]

LGTM!

[gavxue]

Looks good! 👍

[gavxue]

nit: error message should be "failed to delete"

[gavxue]

nit: error message should be "failed to bulk delete"

[ruiichen]

LGTM!