Skip to content

[INTF25] Query to Fetch Applicants to Review#89

Merged
mxc-maggiechen merged 6 commits intomainfrom
INTF25-fetch-applicant-review-query
Feb 3, 2026
Merged

[INTF25] Query to Fetch Applicants to Review#89
mxc-maggiechen merged 6 commits intomainfrom
INTF25-fetch-applicant-review-query

Conversation

@ruiichen
Copy link
Collaborator

@ruiichen ruiichen commented Nov 15, 2025

Notion ticket link

Build Queries to Fetch Applicants to Review

Implementation description

  • Added getReviewedApplicantsByUserId under backend/typescript/services/reviewPageService.ts to fetch information about all of the applicants assigned to a user to review
  • Misc model changes to support the sequelize query for this.
  • Added to backend/typescript/graphql/resolvers/reviewPageResolver.ts
  • Added to backend/typescript/graphql/types/reviewPageTypes.ts

Steps to test

  1. In PGAdmin4, change the values of the entries in tables such as applicants, applicant_records, reviewed_applicant_records, and users, and test on http://localhost:5000/graphql
  2. For reference, the testing config was shown below
    (users)
image (`reviewed_applicant_records`) image (`applicant_records`) image (`applicants`) image image image image image

What should reviewers focus on?

  • 💀 I think we mentioned phasing out enums, so i returned status as string since it doesn't really serialize nicely in GQL types.
  • Overall goal is met.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@ruiichen ruiichen self-assigned this Nov 15, 2025
@ruiichen ruiichen force-pushed the INTF25-fetch-applicant-review-query branch from 6f3addb to 8a41543 Compare November 26, 2025 02:36
ruiichen added 6 commits November 29, 2025 13:32
# Conflicts:
#	backend/typescript/services/implementations/reviewPageService.ts
@ruiichen ruiichen force-pushed the INTF25-fetch-applicant-review-query branch from 5145e0e to 3f8ff44 Compare November 29, 2025 18:33
Copy link
Member

@ericahan22 ericahan22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Copy link
Contributor

@mxc-maggiechen mxc-maggiechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mxc-maggiechen mxc-maggiechen merged commit b419383 into main Feb 3, 2026
1 check passed
@mxc-maggiechen mxc-maggiechen deleted the INTF25-fetch-applicant-review-query branch February 3, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants