Skip to content

[INTF25] Add skill category to reviewd#93

Merged
mxc-maggiechen merged 1 commit intomainfrom
INTF25-add-skill-category-to-reviewed
Nov 26, 2025
Merged

[INTF25] Add skill category to reviewd#93
mxc-maggiechen merged 1 commit intomainfrom
INTF25-add-skill-category-to-reviewed

Conversation

@mxc-maggiechen
Copy link
Contributor

@mxc-maggiechen mxc-maggiechen commented Nov 26, 2025

Notion ticket link

Implementation description

  • Add skillCategory column to Reviewed Applicant Records table

Steps to test

  1. Run docker-compose up to start the docker daemon
  2. Run docker exec recruitment_tools_backend node migrate up to run the migration
  3. Open pgAdmin and use the query SELECT * from reviewed_applicant_records to verify that appropriate column changes are made - i.e. a column called skillCategory of type string is added to the table
  4. Run docker exec recruitment_tools_backend node migrate down to undo migration
  5. Open pgAdmin and use the query SELECT * from reviewed_applicant_records to verify that appropriate column changes are made - i.e. a column called skillCategory of type string is removed from table

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Member

@ericahan22 ericahan22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@mxc-maggiechen mxc-maggiechen merged commit daecb44 into main Nov 26, 2025
1 check passed
@mxc-maggiechen mxc-maggiechen deleted the INTF25-add-skill-category-to-reviewed branch November 26, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants