-
Notifications
You must be signed in to change notification settings - Fork 1
[INTF25] Implement Delegation Algorithm & Mutator #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # backend/typescript/graphql/resolvers/reviewDashboardResolvers.ts # backend/typescript/services/implementations/reviewDashboardService.ts # backend/typescript/services/interfaces/IReviewDashboardService.ts
72a8eb8 to
353409d
Compare
isabellehuangg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Algorithm makes sense to me! Just added a comment for code clarity
| /* eslint-disable @typescript-eslint/no-non-null-assertion */ | ||
| const [count, userIds] = FSM.get(record.position)!; | ||
| let newCount = count; | ||
| const assignedReviewer1 = FSM.get(record.position)![1][newCount]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Could FSM.get(record.position)![1] be replaced by userIds from line 220?
mxc-maggiechen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Notion ticket link
Ticket Name
Implementation description
Steps to test
reviewed_applicant_recordstable:DELETE FROM reviewed_applicant_records;applicant_recordstable:SELECT * FROM applicant_records WHERE position='VP Engineering';userstable:SELECT * FROM users WHERE position='VP Engineering';What should reviewers focus on?
Checklist