Skip to content

Conversation

@ericahan22
Copy link
Member

@ericahan22 ericahan22 commented Nov 26, 2025

Notion ticket link

Build Review Status Mutator

Implementation description

  • Added new ReviewStatus type (SEPARATE FROM ReviewStatusEnum)
    • Note changes from Todo -> Needs Review and Conflict -> Conflict Reported
  • Added updateReviewStatus service to update the status of a reviewed applicant record
  • Added corresponding queries/types

Steps to test

  1. Open up pgAdmin and insert a row into reviewed_applicant_records (note that reviewerId is an integer):
     INSERT INTO "reviewed_applicant_records" (
       "applicantRecordId",
       "reviewerId",
       "review",
       "status",
       "score",
       "reviewerHasConflict",
       "createdAt",
       "updatedAt"
     ) VALUES (
       '60909d6c-8da0-4692-9c7d-0135dfa78daa',
       1,
       '{}',
       'NeedsReview',
       NULL,
       false,
       CURRENT_TIMESTAMP,
       CURRENT_TIMESTAMP
     );
    
  2. Open http://localhost:5000/graphql and ensure the following mutation works:
     mutation {
       updateReviewStatus(applicantRecordId: "60909d6c-8da0-4692-9c7d-0135dfa78daa", reviewerId: 1, status: ConflictReported) {
         applicantRecordId,
         reviewerId
         status
         score,
         reviewerHasConflict,
       }
     }
    
  3. Verify that the status changes in pgAdmin, and also try an invalid status (e.g., Todo) and make sure it doesn't work.

What should reviewers focus on?

  • Maybe double-check that there aren't duplicate files, e.g., reviewedApplicantRecordResolver.ts vs reviewedApplicantRecordResolvers.ts (Resolvers plural)
  • Check the implementation of updateReviewStatus

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@ericahan22 ericahan22 self-assigned this Nov 26, 2025
@mxc-maggiechen mxc-maggiechen requested a review from gavxue December 3, 2025 01:32
Copy link
Collaborator

@gavxue gavxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor details 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants