Skip to content

Fix duplicate Review type definition#98

Merged
mxc-maggiechen merged 2 commits intomainfrom
fix-duplicate-review-type-definition
Dec 3, 2025
Merged

Fix duplicate Review type definition#98
mxc-maggiechen merged 2 commits intomainfrom
fix-duplicate-review-type-definition

Conversation

@gavxue
Copy link
Collaborator

@gavxue gavxue commented Nov 29, 2025

Noticed that we accidentally defined the Review type twice for graphql. We just need to remove one.

Before:

  • after running docker-compose up
- recruitment_tools_backend  | /app/node_modules/graphql/validation/validate.js:107
recruitment_tools_backend  |     throw new Error(errors.map(function (error) {
recruitment_tools_backend  |           ^
recruitment_tools_backend  | Error: There can be only one type named "Review".
recruitment_tools_backend  | 
recruitment_tools_backend  | Field "Review.passionFSG" can only be defined once.
recruitment_tools_backend  | 
recruitment_tools_backend  | Field "Review.teamPlayer" can only be defined once.
recruitment_tools_backend  | 
recruitment_tools_backend  | Field "Review.desireToLearn" can only be defined once.
recruitment_tools_backend  | 
recruitment_tools_backend  | Field "Review.skill" can only be defined once.
recruitment_tools_backend  | 
recruitment_tools_backend  | Field "Review.skillCategory" can only be defined once.
recruitment_tools_backend  |     at assertValidSDL (/app/node_modules/graphql/validation/validate.js:107:11)
recruitment_tools_backend  |     at Object.buildASTSchema (/app/node_modules/graphql/utilities/buildASTSchema.js:45:34)
recruitment_tools_backend  |     at Object.buildSchemaFromTypeDefinitions (/app/node_modules/graphql-tools/src/generate/buildSchemaFromTypeDefinitions.ts:45:32)
recruitment_tools_backend  |     at makeExecutableSchema (/app/node_modules/graphql-tools/src/makeExecutableSchema.ts:52:16)
recruitment_tools_backend  |     at Object.<anonymous> (/app/graphql/index.ts:41:46)
recruitment_tools_backend  |     at Module._compile (node:internal/modules/cjs/loader:1369:14)
recruitment_tools_backend  |     at Module.m._compile (/app/node_modules/ts-node/src/index.ts:1618:23)
recruitment_tools_backend  |     at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
recruitment_tools_backend  |     at Object.require.extensions.<computed> [as .ts] (/app/node_modules/ts-node/src/index.ts:1621:12)
recruitment_tools_backend  |     at Module.load (node:internal/modules/cjs/loader:1206:32)
recruitment_tools_backend  | [nodemon] app crashed - waiting for file changes before starting...

After:

  • running docker-compose up should not cause any errors

@gavxue gavxue marked this pull request as ready for review November 29, 2025 19:57
Copy link
Collaborator

@ruiichen ruiichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work 👍🏻

Copy link
Contributor

@mxc-maggiechen mxc-maggiechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mxc-maggiechen mxc-maggiechen merged commit 991e613 into main Dec 3, 2025
1 check passed
@mxc-maggiechen mxc-maggiechen deleted the fix-duplicate-review-type-definition branch December 3, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants