[INTW26] Conflict Dialog #247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin Node version to match supported builds
Improve error reporting and validate response shape
Create a shared modal wrapper based on MUI Dialog
Add reportReviewConflict mutation and client wrapper
Show confirm and success dialogs and call the report mutation
Relocate ProtectedApplication into components and update imports
Tighten types and routing for review tables and stages
mxc-maggiechen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Implement Report Conflict Feature
Implementation description
Dialoguetemplate built on MUIDialog(components/common/Dialogue.tsx)components/review/stages/reviewInfoStage.tsx)reportReviewConflictGraphQL mutation ingraphql/queries.tsReviewPageAPIClientto call the mutation (APIClients/ReviewPageAPIClient.ts)Steps to test
nvm use 18npm run lint:tscnpm run build/review?reviewId=<id>Conflictand verify the confirm dialog opensCanceland verify it closesYes, reportand verify the mutation is called and the success dialog opensWhat should reviewers focus on?