Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneTBB] Update task_scheduler_observer_cls.rst #601

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[oneTBB] Update task_scheduler_observer_cls.rst #601

merged 1 commit into from
Feb 6, 2025

Conversation

aepanchi
Copy link
Contributor

Remove the mentions of global usage of task_scheduler_observer.

vossmjp
vossmjp approved these changes Dec 5, 2024
View reviewed changes
Copy link

@vossmjp vossmjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@akukanov akukanov added the TBB label Feb 4, 2025
@akukanov akukanov requested a review from kboyarinov February 4, 2025 00:06
@akukanov akukanov added the bug Something isn't working label Feb 4, 2025
akukanov
akukanov approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@akukanov akukanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. Essentially, it's a bug fix, since there is no global observers in oneTBB. Ideally it should be added to a revision of the specification v1.4.

kboyarinov
kboyarinov approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@kboyarinov kboyarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@akukanov akukanov merged commit 96e2e03 into uxlfoundation:main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vossmjp vossmjp vossmjp approved these changes

@akukanov akukanov akukanov approved these changes

@kboyarinov kboyarinov kboyarinov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working TBB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aepanchi @vossmjp @akukanov @kboyarinov